bootstrap: check existence of openssl's commands #4059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It calls openssl's commands 'dhparam' and 'pkcs12' in script bootstrap which are configurable based on openssl configure options 'no-dh' and 'no-des'. So check existence of these commands. If not exist, abort from running of the script. 1. https://github.com/openssl/openssl/blob/master/apps/build.info#L37 2. https://github.com/openssl/openssl/blob/master/apps/build.info#L22 Signed-off-by: Kai Kang <kai.kang@windriver.com>
kkang-wr
changed the title
|
This just aborts the entire script if those commands don't exist. Why not check for the existence of the commands, and skip them if they don't exist? i.e. |
|
I suppose these openssl commands are essential to create certificates in this scripts. Without these commands, script bootstrap should be unfunctional. |
|
You can always run the scripts on another system. So these aren't critical fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It calls openssl's commands 'dhparam' and 'pkcs12' in script bootstrap
which are configurable based on openssl configure options 'no-dh' and
'no-des'. So check existence of these commands. If not exist, abort from
running of the script.
Signed-off-by: Kai Kang kai.kang@windriver.com