NULL check needs to be moved before using strchr #4115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new block checking
ecdh_curve
values was introduced before the existing check on whetherecdh_curve
was NULL.Having
ecdh_curve
NULL is at least possible from trustrouter.c, where a newfr_tls_server_conf_t
struct is created and initialised to 0.This resulted in SIGSEGVs when using the trustrouter module.