Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: Don't call detach after failed perl_parse #802

Merged
merged 1 commit into from Oct 1, 2014
Merged

perl: Don't call detach after failed perl_parse #802

merged 1 commit into from Oct 1, 2014

Commits on Sep 30, 2014

  1. perl: Don't call detach after failed perl_parse 

    Don't call "detach" callback in rlm_perl, if perl_parse of the Perl
module failed.

This fixes segfault when the module file cannot be read:

    Can't open perl script "/etc/raddb/mods-config/perl/example.pl": Permission denied
    rlm_perl: perl_parse failed: /etc/raddb/mods-config/perl/example.pl not found or has syntax errors.
    /etc/raddb/mods-enabled/perl[7]: Instantiation failed for module "perl"
    Segmentation fault
    @spbnick
    spbnick committed Sep 30, 2014
    Copy the full SHA
    e811b8e View commit details
    Browse the repository at this point in the history