ctrl-enter toggles fullscreen (in addition to ctrl-alt-enter)

[sirianni]

In FreeRDP 1.0.1 both 'ctrl-enter' and 'ctrl-alt-enter' toggle FullScreen mode. This is problematic since ctrl-enter is a standard shortcut in applications like MS Outlook for "Send Email".

The man page states that 'ctrl-alt-enter' is the shortcut.

[arpiondarkness]

Hi, to solve this issue try to redirect both stderr and stdout to "fake" file likes this:

xfreerdp -u USERNAME -d DOMAIN -f --plugin cliprdr REMOTECLIENT 2>&1 fakeFILE

I'm using freerdp 0.8.2 on FC14 and it works fine with win7 / outlook 2010

[dorianj]

What OS are you seeing this on? On Ubuntu 12.04, only ctrl-enter triggers the key shortcut for me.

The code is thus:

        if ((xf_kbd_key_pressed(xfi, XK_Alt_L) || xf_kbd_key_pressed(xfi, XK_Alt_R))
            && (xf_kbd_key_pressed(xfi, XK_Control_L) || xf_kbd_key_pressed(xfi, XK_Control_R)))
        {
            /* Ctrl-Alt-Enter: toggle full screen */
            xf_toggle_fullscreen(xfi);
            return true;
        }

so I don't know why it would trigger when only ctrl is pressed.

[sirianni]

Ubuntu 12.04.

Could the issue be when the ALT key is still depressed when focus leaves the RDP window? When the window is re-entered Xfreerdp might still think the ALT key is depressed even though it isn't (the target windows OS does not think that ALT is pressed however)

What leads me to believe this is that pressing the ALT key a bunch of times in the RDP session "resets" the condition and then CTRL-ENTER works as expected (does not toggle fullscreen).

[dorianj]

Good thinking, that's probably the most likely scenario.

Some other clients use extra logic on gaining and losing focus to clear these things.

I'll leave this open, it's certainly an annoying bug to live with.

[pfmooney]

I've encountered this issue as well. As sirianni, mentioned, it has to do with keys being depressed when the window loses focus. Depending on your WM and how it's configured, the problem can appear often.

Clearing the data structure of depressed keys on loss of focus would alleviate the problem.

[pfmooney]

I've published my fix here:
pfmooney@7cf594a

While it solve the unwanted full-screen initiation due to the alt key, it should be noted that keys are still assumed to be depressed inside the RDP session. That becomes an issue for me when using the Win key as a modifier in my WM. If the Win key is depressed when xfreerdp loses focus, letters typed in the window after I return behave as if I'm still holding the key (such as 'r' opening the run dialog). A call to "xf_kbd_release_all_keypress" during focus-out but prior to the xf_kbd_clear (perhaps as part of it) would solve that problem.
I did not include that in my commit as I was unsure of negative effects elsewhere.

Feedback would be appreciated.

[pfmooney]

Does anyone have input on how I should go about pursuing the inclusion of that fix in one form or another?

[dorianj]

@pfmooney Submit a pull request.

[pfmooney]

Will do. Thanks.

[bmiklautz]

Fixed in master with commit 7cf594a