-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POSIX clipboard (wClipboard) produces on master invalid file lists #8350
Comments
The issue is likely in the POSIX clipboard part. A month or two ago, things just worked fine. So, any recent PRs in that area are possible candidates where things went wrong. |
@pnowack ok, can not reproduce here on fedora 36 with gnome/nautilus. (copied my whole download folder with many subolders, android studio, ... in it) |
@akallabeth that's weird. In any case, the error is with xfreerdp from the master branch and the nautilus version on the client side here 43.0 (am on Arch) In the screencast, where I close the xfreerdp3 window, the terminal output is seen and lots of |
Could you retry this with the
Does this also apply to the file changed dates here (i.e. not 1601, but actual date, that is also used on the client side for the respective file(s))? |
When preparing the uri-list for a file list of copied files, only the actual selected files and folders need to be included in the uri-list, since files in subfolders are automatically handled. To check for the selected files, gnome-remote-desktop only checks for the backslash ('\\') operator, but not also for the slash operator ('/'), which could lead to errors during the pasting operation, even though the use of the slash operator in file lists is discouraged. Fix this situation by also accounting for the slash operator, when preparing uri-lists. See also: FreeRDP/FreeRDP#8350
When trying to copy paste a folder (containing files) with xfreerdp3 (master), the submitted file list is invalid. A lot of file-replace dialogs are shown for each entry (where as the former file seems to always be 0 Bytes) and the attributes (the creation date) is invalid.
Reproduction steps:
ogon-channels
repo for this (small repo, lots of files).Observation:
You get a lot of file-replace dialogs and the file creation attribute is invalid. Also, the contents of the folder themselves are in the top level directory too.
These issue don't happen with xfreerdp2 (stable-2.0 branch).
Screencast of the issue:
Bildschirmaufzeichnung.vom.2022-10-27.09-15-11.webm
In the screencast, first xfreerdp3 (master) is used to try to copy-paste the folder (where you can see, that it fails with the errors mentioned above).
Then xfreerdp2 (stable-2.0) is used, where everything works fine.
The text was updated successfully, but these errors were encountered: