Bug: Glyph out of bounds with Glyph-cache

[JSSSSSSSSSS]

When connect to win2k8 with Glyph-cache on, the glyph of notepad out of bounds. see:

more information:
Application details

• FreeRDP version :2.11.2
• cmdline: xfreerdp /v:xx /u:xxx /p:xxx /bitmap-cache /glyph-cache -fonts
• Output of xfreerdp /buildconfig
• OS version connecting to (server side): win2k8

And I step through the code in libfreerdp/cache/Glyph.c and found that there is a call of SetBounds in update_process_glyph_fragments. Also gdi_SetClipRng and gdi_SetNullClipRng in function gdi_Glyph_BeginDraw and gdi_Glyph_EndDraw in libfreerdp/gdi/graphics.c. What I want to say is that when deal with Primary drawing orders , it already has a bounds field. These clip operations clear the limit of bounds from Primary drawing orders.
And I comment these "Redundant clip" calls, it works fine for me.

What is the real problem ?

[JSSSSSSSSSS]

One more, when dealing with Primary drawing orders-- GlyphIndex, in the VariableBytes field, the 'USE' also has a delta Bytes.

Mssing dealing with delta Bytes in update_process_glyph_fragments.

[akallabeth]

@JSSSSSSSSSS ok, looks like you already found the fix.
would be great if you could create a pull request ;)

the issue here is that you use a code path that is rarely in use (2k8 already supports at least rfx) so there are not too many testers going through this.

[JSSSSSSSSSS]

ok, mark