Sometimes cannot resize client on Mac [deprecated client]

[rcarmo]

Describe the bug

Building from git tip, the SDL client does not let me resize the window, and switching to full screen does not seem to update the display size either.

To Reproduce

Running with these options:

./install/MacFreeRDP.app/Contents/MacOS/MacFreeRDP /gfx:rfx,progressive +rfx /rfx-mode:video /sound /w:1920 /h:1080 +dynamic-resolution /v:fedora.local /u:me

Removing w or h does not help, +workarea doesn't seem to work either. There is no cursor feedback regarding the local window being resizable, either, which to me feels like a window creation bug (why isn't the CoreGraphics code handling window resizes)?

Expected behavior

The cursor should change when hovering over a window edge and I should be able to resize the SDL client and have the remote display area increase accordingly.

• OS version connecting to (server side): Fedora using stock xrdp. Other clients work OK.

[akallabeth]

can not reproduce.
a build from current f3c0d22 runs just fine with mouse cursor switching to resize mode on window border like other mac apps.

[edit] did just run ./scripts/bundle-mac-os.sh with ninja, meson and autotools from ports installed

[rcarmo]

I did a git pull 6 hours ago and did not see that (same build process, but my tools come from brew). Did you use the same command line?

[akallabeth]

yes, same command line.
the border is a bit thin though, maybe just missed it?

[edit] fullscreen switch seems to sometimes screw up session resizing though

[rcarmo]

I am trying to rebuild from a clean tree on a new machine. Mind sharing your cmake settings?

Mine are:

git clean -xdf
cmake -S . -B build -DCMAKE_OSX_ARCHITECTURES="arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET=14 -DWITH_CLIENT_MAC=on -DWITH_X11=off -DBUILD_SHARED_LIBS=on -DCMAKE_BUILD_TYPE=Release -DWITH_WEBVIEW=on -DWITH_MANPAGES=off -DBUILD_SHARED_LIBS=on
# if this isn't run under bash it will fail
bash ./scripts/bundle-mac-os.sh

[rcarmo]

I just rebuilt the whole thing from scratch on my laptop (as in: from a completely new git clone) and the window is not resizable, as you can see in this screen recording:

Untitled.mp4

The command line I used is:

./install/MacFreeRDP.app/Contents/MacOS/MacFreeRDP /gfx:rfx,progressive +rfx  /sound  +dynamic-resolution /v:xfce.local /u:me

Can we reopen the issue, please?

[akallabeth]

@rcarmo well, you intentionally break the build ;)
you run the script on a clean checkout OR you run cmake yourself ;)

[rcarmo]

I was using cmake in order to try to bisect the issue. Using the script directly (again, on a clean checkout) yields a build that has exactly the same problem. Can you not reproduce this at all? Are you using brew and Sonoma?

…

On 21 Feb 2024, at 06:43, akallabeth ***@***.***> wrote: @rcarmo <https://github.com/rcarmo> well, you intentionally break the build ;) you run the script on a clean checkout OR you run cmake yourself ;) — Reply to this email directly, view it on GitHub <#9882 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC7323D7WBTC7HRL6JMELLYUWJRVBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFU4YTSNZZG44TPAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMJUGQ2DKNZVGI22O5DSNFTWOZLSUZRXEZLBORSQ>. You are receiving this email because you were mentioned. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[akallabeth]

1. brew or ports does not really matter, it is just used to compile the stuff
2. yes, an M1 with Sonoma 14.3.1

so, just to be sure I did run it again and today there seems to be something different? same binary, same command line but the window resize arrows no longer appeared. (not even an update/restart of the machine, just arrow up in the still open bash to run the same connection again)

so I think this might be some race on startup (by default the window is not resizable, but if /dynamic-resolution is added this property is updated)

[akallabeth]

@rcarmo FYI: you did run the deprecated mac client, not the SDL client. (the warning messages in the CLI are quire obvious ;))

[rcarmo]

Well, the docs aren't clear on how to run the SDL one, and the "deprecated" one is still building and generating a working .app, so... I thought that was the SDL one.

How do I get only the SDL binary to build with the standard Mac script, so that we can all agree on how to reproduce this?

[akallabeth]

you seem to misunderstand the purpose of the script.
It is building a MacOS bundle so that all dependencies and library RPATH are set so you can run it on any mac.
but it contains all binaries that can be used:

ls -l install/MacFreeRDP.app/Contents/MacOS
total 5256
-rwxr-xr-x  1 dev  staff   172264 Feb 21 09:12 MacFreeRDP
-rwxr-xr-x  1 dev  staff   185896 Feb 21 09:12 faac
-rwxr-xr-x  1 dev  staff   168392 Feb 21 09:12 faad
-rwxr-xr-x  1 dev  staff   100320 Feb 21 09:12 freerdp-proxy
-rwxr-xr-x  1 dev  staff   133312 Feb 21 09:12 freerdp-shadow-cli
-rwxr-xr-x  1 dev  staff  1459800 Feb 21 09:12 sdl-freerdp
-rwxr-xr-x  1 dev  staff   102808 Feb 21 09:12 sfreerdp
-rwxr-xr-x  1 dev  staff   142368 Feb 21 09:12 sfreerdp-server
-rwxr-xr-x  1 dev  staff   100024 Feb 21 09:12 winpr-hash
-rwxr-xr-x  1 dev  staff    99152 Feb 21 09:12 winpr-makecert

[rcarmo]

Well, that certainly isn't documented well enough (I saw the Libraries folder, and the bundle defaults to the client, so...). Thanks, I will give it a whirl.