Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add coverity scheduled workflow #10058

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

chipitsine
Copy link
Contributor

@chipitsine chipitsine commented Apr 8, 2024

please find a scheduled coverity scan workflow

  1. I hope it is considered useful
  2. I hope that someone has admin access to https://scan.coverity.com/projects/freerdp
  3. token must be copied from coverity to COVERITY_SCAN_TOKEN secret
  4. coverity wants valid email (I specified "someone@example.com")

thanks for attention ))

@freerdp-bot
Copy link

Can one of the admins verify this patch?

Copy link

github-actions bot commented Apr 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@akallabeth
Copy link
Member

will check tomorrow regarding the credentials. someone in the project has them, but as you can see they have not been used for quite some time (before I joined the project actually 😁 )

Copy link

github-actions bot commented Apr 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, now we recovered the credentials, they were buried deep 😁

a few more changes and we can merge and do a first test upload!

.github/workflows/coverity.yml Show resolved Hide resolved
.github/workflows/coverity.yml Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
@chipitsine chipitsine marked this pull request as ready for review April 10, 2024 19:41
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akallabeth
Copy link
Member

@freerdp-bot test

@akallabeth akallabeth added this to the next-3.0 milestone Apr 11, 2024
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11738/

@akallabeth akallabeth merged commit be9df8d into FreeRDP:master Apr 11, 2024
4 checks passed
@chipitsine chipitsine deleted the coverity_workflow branch April 11, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants