Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity #10068

Merged
merged 33 commits into from
Apr 12, 2024
Merged

Coverity #10068

merged 33 commits into from
Apr 12, 2024

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Apr 11, 2024

pull complete so far, will create another one with the remaining (low priority code cleanup) fixes

@akallabeth akallabeth added this to the next-3.0 milestone Apr 11, 2024
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11749/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/Wayland/wlf_cliprdr.c Show resolved Hide resolved
client/common/cmdline.c Outdated Show resolved Hide resolved
libfreerdp/codec/ncrush.c Outdated Show resolved Hide resolved
libfreerdp/codec/ncrush.c Outdated Show resolved Hide resolved
winpr/libwinpr/path/path.c Show resolved Hide resolved
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11750/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11751/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11752/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11753/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11754/

@chipitsine
Copy link
Contributor

too many fixes ))
worth adding a badge to README

@akallabeth
Copy link
Member Author

too many fixes )) worth adding a badge to README

will do once we´re through with the reports.

@akallabeth akallabeth mentioned this pull request Apr 12, 2024
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11756/

@mfleisz mfleisz merged commit 1466d70 into FreeRDP:master Apr 12, 2024
5 checks passed
@akallabeth akallabeth deleted the coverity branch April 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants