shadow: mention in "help" output that auth defaults to "required" #10099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's marked as "off" currently but it is "on" by default.
|
Can one of the admins verify this patch? |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freerdp-shadow-clirequires authorization by default, however the help output was saying:Fix that.
Alternatively, since FreeRDP is very peculiar in how it handles command line options, it's possible that the phrase
-auth (default:off)was referring to the inverse logic of-authdisabling authorization andoffinverting the disabling, and then the complete-auth (default:off)was presumed to imply "enabled". Tell me if that's so, in which case that still needs to be changed because that's very confusing, especially for anyone coming from other cmdline utilities background.