-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timezone fixes #10106
Timezone fixes #10106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, one nitpick ;)
The TZ variable may either contain a direct timezone representation, or a reference to a file in tzfile(5) format. Mapping a direct timezone representation to a Windows timezone would be difficult. According to tzset(3), a file reference should start with a colon, though glibc treats it as optional. It may be an absolute path or a path relative to /usr/share/zoneinfo. Adjust winpr_detect_windows_time_zone to accept either.
Populate StandardName and DaylightName with 2-byte WCHAR values instead of 4-byte wchar_t values on Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
A couple minor fixes for timezone detection in winpr. See commit messages for detail.