Jsonc #10183
Jsonc #10183
Conversation
|
@ondrejholy did take your pr and moved the stuff to |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
* Add module for cJSON * Add module for json-c
as we now support cJSON and json-c we need to wrap the functions we use. also allows drop in replacements for older cJSON versions lacking certain functions.
use the new WinPR JSON wrapper API
|
@ondrejholy ok, did implement the generic |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Refer to this link for build results (access rights to CI server needed): |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@ondrejholy did cherry-pick your commits to this pr. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test please |
|
Refer to this link for build results (access rights to CI server needed): |
Currently, the `arm_handle_bad_request` function returns `FALSE` when the `cJSON_ParseWithLength` function fails to parse the message, but only when the `cJSON_GetErrorPtr` returns a valid pointer. It would be better to return regardless of the `cJSON_GetErrorPtr` return value.
Although, the `pkg_check_modules` function is used when finding the json-c library, the results are never used. Let's add the `HINTS` params for the `find_path` and `find_library` functions.
This is in preparation for the subsequent commit adding test case for the prefs functionality to avoid building the code twice.
The WINPR_JSON_FOUND macro is never defined currently. Consequently, the SDL prefs always use the fallback implementation. Let's use the WITH_WINPR_JSON instead to really parse the sdl-freerdp.json file.
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
* pkg-config sets CJSON_FOUND, check for that instead of the paths, which might be unset or set to <var>-NOTFOUND * move detection to own file. find_package targets are meant to be used in same directory or below, but we define the WinPR target one above, so include it in parent
|
@ondrejholy ok, did have to remove the SDL tests:
|
|
Refer to this link for build results (access rights to CI server needed): |
|
Hmm, right. It is not a problem to replace The config path is overridden over the But since we have the JSON wrapper now, it should not be hard to add some generic tests for the wrapper itself... would you like me to prototype something? |
I think the whole |
|
I´ll have a look at the rewrite of the |
Replaces #10178