Fix extended mouse event to register the click for forward/back buttons #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the members verify this patch? |
|
@freerdp-bot test. |
|
Test PASSed. |
awakecoding
added a commit
that referenced
this pull request
Oct 17, 2013
Fix extended mouse event to register the click for forward/back buttons
|
Has there been a release with this fix? |
|
I don't think there has been a release with this fix yet, and in fact it looks like there hasn't been an official release since 2012. For my purposes, I've been building from the latest source to get a working back button. I think there was some discussion on the developer mailing list about the release plans, so maybe inquire there if needed. |
|
@freerdp-bot release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first github submission, so hopefully I got everything right… If not, I'm happy to fix it and re-submit.
For X11 clients, the extended mouse buttons (back / forward) do not seem to be passed through to the RDP server. I've been having this problem with a Logitech m510 mouse and multiple Ubuntu versions connecting to a Windows 8 machine. The back buttons work locally (in firefox, etc.) but are not passed to the RDP server. This problem has also been reported by others in both FreeRDP and Remmina:
http://forums.debian.net/viewtopic.php?f=30&t=104772
http://sourceforge.net/mailarchive/message.php?msg_id=29017116
The following pull request addressed this topic, at least partially. However, while the patch recognized the button events in xf_event.c, it did not actually apply them in xf_input_extended_mouse_event in xf_input.c.
#533
I've made a simple adjustment to xf_input.c to correct this issue, and the back and forward buttons work correctly now. Submitting the updated code for inclusion in the master branch.