Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uclibc build fixes and recompressed images #2024

Merged
merged 8 commits into from Aug 18, 2014
Merged

Conversation

repzilon
Copy link
Contributor

@repzilon repzilon commented Aug 7, 2014

Corrections to the FreeRDP trunk to support uclibc

References
https://bugs.gentoo.org/show_bug.cgi?id=497808
#1660

Also included a lossless image recompression in two other commits (how do I cherry-pick a commit for a pull request?)

…tead of futimes.

* Borrowed eventfd_read and eventfd_write from bionic for uclibc compatibility (uclibc headers are broken unfortunately). Bionic and
FreeRDP are both under the Apache 2.0 license.
@freerdp-bot
Copy link

Can one of the members verify this patch?

@bmiklautz
Copy link
Member

@freerdp-bot test

@bmiklautz
Copy link
Member

@repzilon what's the re-compression good for?

@freerdp-bot
Copy link

Test FAILed.
Refer to this link for build results: https://ci.freerdp.com/job/PullRequestBuilder/526/

@repzilon
Copy link
Contributor Author

repzilon commented Aug 7, 2014

The recompression shaves about 600kb out of the source distribution and save a few kb for iOS and Android packages (their image recompression stage in Release mode just uses one utility)

@bmiklautz
Copy link
Member

@freerdp-bot test.

@bmiklautz
Copy link
Member

@freerdp-bot test

@freerdp-bot
Copy link

Test PASSed.
Refer to this link for build results: https://ci.freerdp.com/job/PullRequestBuilder/545/

@repzilon
Copy link
Contributor Author

The test passed. What is needed now?

@bmiklautz
Copy link
Member

+1

awakecoding added a commit that referenced this pull request Aug 18, 2014
uclibc build fixes and recompressed images
@awakecoding awakecoding merged commit f30d7cf into FreeRDP:master Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants