(hopefully) proper window style setup in wfreerdp at startup #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the members verify this patch? |
|
@freerdp-bot test |
|
Test PASSed. |
|
just seen that the problem still persists if wfreerdp is minimized and maximized again |
|
@freerdp-bot test. |
|
Test FAILed. |
awakecoding
added a commit
that referenced
this pull request
Sep 5, 2014
(hopefully) proper window style setup in wfreerdp at startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting with wfreerdp, sometimes the wfreerdp window seems to be not created in full size like here: #2047. That means both scrollbars are shown and the client area of the window seems to be smaller than the requested size (rdp-session resolution). This seems to only happen randomly, but it might be solved by setting up the window's style attributes already with CreateWindowEx(), because when setting the WS_SIZEBOX attribute later (and resizing the window (?)), it seems to end up in unexpected behaviour. The window size is set wrongly, because GetClientRect() seems to return wrong values and canvas diff is set too small? Hopefully this is a real fix, please feel free to correct me anytime!