Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac os ssl warning fix #3110

Merged
merged 3 commits into from Feb 11, 2016
Merged

Conversation

akallabeth
Copy link
Member

No description provided.

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/954/

@mfleisz
Copy link
Member

mfleisz commented Feb 4, 2016

+1

@hardening
Copy link
Contributor

@akallabeth I guess it will only build with recent of MacOS X then ?

@akallabeth
Copy link
Member Author

@hardening Should only depend on the OpenSSL version used or do you know another reason for this removed const argument?

@hardening
Copy link
Contributor

@akallabeth yeah you're right, so the fix should be that the #ifdef would be a #if openssl_version > XXX isn't it ?

@akallabeth
Copy link
Member Author

@hardening Just checked, this (old) API applies to all OpenSSL versions < 1.0.0. But neither gcc nor clang complain about the const argument when compiling against 0.9.8zh

@akallabeth
Copy link
Member Author

@hardening Ok, clang actually does complain. Looks like my cache was not up to date, forget the comment above.

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/967/

@mfleisz
Copy link
Member

mfleisz commented Feb 11, 2016

Any objections on merging this one?

@hardening
Copy link
Contributor

+1

hardening added a commit that referenced this pull request Feb 11, 2016
@hardening hardening merged commit cbd1ffa into FreeRDP:master Feb 11, 2016
@akallabeth akallabeth deleted the mac_os_ssl_warning_fix branch February 12, 2016 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants