winpr: _IoCreateDeviceEx: fix mkdir error check #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
reviewed
Oct 30, 2017
winpr/libwinpr/io/device.c
Outdated
| @@ -138,7 +138,7 @@ NTSTATUS _IoCreateDeviceEx(PDRIVER_OBJECT_EX DriverObject, ULONG DeviceExtension | |||
|
|
|||
| if (!PathFileExistsA(DeviceBasePath)) | |||
| { | |||
| if (!mkdir(DeviceBasePath, S_IRUSR | S_IWUSR | S_IXUSR)) | |||
| if (mkdir(DeviceBasePath, S_IRUSR | S_IWUSR | S_IXUSR)) | |||
There was a problem hiding this comment.
Maybe a good idea to write something like if (mkdir(DeviceBasePath, S_IRUSR | S_IWUSR | S_IXUSR) != 0) to indicate the integer nature of the return
There was a problem hiding this comment.
I force-pushed a revised commit.
akallabeth
approved these changes
Oct 30, 2017
hardening
approved these changes
Oct 30, 2017
The mkdir(2) function returns 0 on success, and -1 on error. This resolves an error in TestIoDevice when /tmp/.device/ does not exist. Bug: https://bugs.gentoo.org/635838
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mkdir(2) function returns 0 on success, and -1 on error.
This resolves an error in TestIoDevice when /tmp/.device/ does not
exist.
Bug: https://bugs.gentoo.org/635838