Fixed RAIL window can't show again once hidden #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause is very simple: we didn't map the xwindow on receiving WINDOW_SHOW. but doing that causes another problem that you can't hide a window anymore, and that is because whlie window hiding, the _NET_WM_STATE and WM_STATE properies of the xwindow may change, in the function `xf_event_PropertyNotify` we just assume that windows not maximized, not minimized, yet not showing normally should be corrected to be shown, we just need to consider the situation that the window is hidden here. fix: FreeRDP#5078
|
Can one of the admins verify this patch? |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
@hualet Thank you, will have a look at it. Don´t know if I manage today but from an initial glance it should be ok. |
akallabeth
approved these changes
Dec 4, 2018
hardening
approved these changes
Dec 4, 2018
|
Wow, PRs get merged so quickly, I'm so impressed :) Good job @akallabeth @hardening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function
xf_event_PropertyNotifywe just assume that windowsnot maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.
fix: #5078