New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RAIL window can't show again once hidden #5097

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@hualet
Copy link
Contributor

hualet commented Dec 4, 2018

The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function xf_event_PropertyNotify we just assume that windows
not maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.

fix: #5078

Fixed RAIL window can't show again once hidden
The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function `xf_event_PropertyNotify` we just assume that windows
not maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.

fix: #5078
@freerdp-bot

This comment has been minimized.

Copy link

freerdp-bot commented Dec 4, 2018

Can one of the admins verify this patch?

@akallabeth

This comment has been minimized.

Copy link
Member

akallabeth commented Dec 4, 2018

@freerdp-bot

This comment has been minimized.

Copy link

freerdp-bot commented Dec 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/3498/

@akallabeth akallabeth added this to the 2.0.0 milestone Dec 4, 2018

@akallabeth

This comment has been minimized.

Copy link
Member

akallabeth commented Dec 4, 2018

@hualet Thank you, will have a look at it. Don´t know if I manage today but from an initial glance it should be ok.

@hardening hardening merged commit 46ffa61 into FreeRDP:master Dec 4, 2018

1 check passed

jenkins: PullRequestTester Build finished.
Details
@hualet

This comment has been minimized.

Copy link
Contributor

hualet commented Dec 6, 2018

Wow, PRs get merged so quickly, I'm so impressed :) Good job @akallabeth @hardening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment