Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added proper latency estimation for winmm sound backend. #5517

Merged
merged 3 commits into from Aug 14, 2019
Merged

Added proper latency estimation for winmm sound backend. #5517

merged 3 commits into from Aug 14, 2019

Conversation

akallabeth
Copy link
Member

Fixes some issues as reported in #5514 with links that have variable latency.

@akallabeth akallabeth added this to the 2.0.0 milestone Aug 12, 2019
hardening
hardening previously approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@hardening hardening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/4018/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/4019/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/4020/

hardening
hardening previously approved these changes Aug 12, 2019
View reviewed changes
@akallabeth
Copy link
Member Author

@hardening Improved latency estimation a bit and implemented missing/broken winpr GetTickCount64 for windows XP. (yea, I know...) as well as some compile issues with windows 7 linking against directX.
If you still like/apporove the changes, please merge :)

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/4029/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/4030/

mfleisz
mfleisz approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@mfleisz mfleisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfleisz mfleisz merged commit e16d559 into FreeRDP:master Aug 14, 2019
@akallabeth akallabeth deleted the winmm_latency branch August 14, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfleisz mfleisz mfleisz approved these changes

@hardening hardening hardening left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akallabeth @freerdp-bot @mfleisz @hardening