XReparentWindow fix #576
Merged
XReparentWindow fix #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… both base 16 "with 0x prefix" or decimal window numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to officially mark it - but this is tied to Issue 209.
Basically two changes here:
The changes under client/X11 are the essential changes to allow the XReparentWindow call to function correctly.
The change to libfreerdp-utils allow the X window ID to be a little more flexible such that a decimal number can be passed in - this is similar to how other applications handle passing in Window IDs. Note that a base 16 Window ID can still be passed in - it just would require the 0x prefix now, rather than being optional.