Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to adjust the tcp ack timeout #5987

Merged
merged 1 commit into from Mar 24, 2020

Conversation

akallabeth
Copy link
Member

On high latency links the default of 9 second timeout might be too
strict. Adjusting this for all users will result in a long time
for connections to fail, so let these with high latency links
adjust the value manually. @CeeMac-git this should address the problem you face.

On high latency links the default of 9 second timeout might be too
strict. Adjusting this for all users will result in a long time
for connections to fail, so let these with high latency links
adjust the value manually.
@akallabeth akallabeth added this to the 2.0.0 milestone Mar 23, 2020
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/4744/

@akallabeth akallabeth requested a review from mfleisz March 23, 2020 15:07
Copy link

@CeeMac-git CeeMac-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be an elegant solution to the issue

@mfleisz mfleisz merged commit 38d1be7 into FreeRDP:master Mar 24, 2020
@akallabeth akallabeth deleted the manual_ack_timeout branch March 24, 2020 11:33
@CeeMac-git
Copy link

pulled down latest master tonight and compiled with cmake, works great, thanks again for adding this feature!

@seamus-45
Copy link

So many years I have been forced to patch it 😆

@akallabeth
Copy link
Member Author

@seamus-45 creating a pull request can help avoid that ;)

@seamus-45
Copy link

@akallabeth not all of us are like C-jedi, but yes, you are right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants