Stable backports #6285
Merged
Stable backports #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5b842bc)
Add a updated version of script for creating the release tarball. If TAG is set the TAG is used otherwise it is tried to detect the last TAG using git describe. (cherry picked from commit 93d6de2)
(cherry picked from commit 8c2c19b)
(cherry picked from commit 004910c)
(cherry picked from commit 25f62ee)
(cherry picked from commit c97c1ca)
LoadLibraryA implementation uses the RTLD_LOCAL flag for dlopen currently. This flag doesn't allow the symbols to be used by the subsequently loaded libraries. This is a problem for the video channel when -DBUILTIN_CHANNELS=OFF is used as it uses functions from the geometry channel. Let's use RTLD_GLOBAL instead to prevent "undefined symbol" errors in such cases. Fixes: FreeRDP#6236 (cherry picked from commit d8cd671)
(cherry picked from commit ea8c922)
(cherry picked from commit 164c00f)
(cherry picked from commit f01ae7d)
…pt produces data, timeout doesn't) (cherry picked from commit 2e4f27a)
(cherry picked from commit 69141aa)
(cherry picked from commit 28e29f8)
The character '>' was being rendered as < instead of >. (cherry picked from commit 98930bf)
This fixes the following defect reported by covscan tool: libfreerdp/gdi/gfx.c:144: missing_unlock: Returning without unlocking "update->mux". (cherry picked from commit 914808f)
This fixes the following defects reported by covscan tool: - client/Wayland/wlf_input.c:251: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10). - client/Wayland/wlf_input.c:308: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10). - client/Wayland/wlf_input.c:360: overrun-local: Overrunning array "contacts" of 10 32-byte elements at element index 10 (byte offset 351) using index "i" (which evaluates to 10). - client/Wayland/wlf_input.c:251: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds. - client/Wayland/wlf_input.c:308: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds. - client/Wayland/wlf_input.c:360: error[arrayIndexOutOfBounds]: Array 'contacts[10]' accessed at index 10, which is out of bounds. - client/Wayland/wlf_input.c:246: uninit_use_in_call: Using uninitialized value "y" when calling "wlf_scale_coordinates". - client/Wayland/wlf_input.c:246: uninit_use_in_call: Using uninitialized value "x" when calling "wlf_scale_coordinates". The maximal number of touches can be higher then 10, see: https://wayland.freedesktop.org/libinput/doc/latest/touchpads.html Let's increse the MAX_CONTACTS count and add checks to prevent usage of uninitialized values. (cherry picked from commit 6ab7996)
This fixes the following defect reported by covscan tool: - channels/smartcard/client/smartcard_pack.c:942: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode". - channels/smartcard/client/smartcard_pack.c:894: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode". - channels/smartcard/client/smartcard_pack.c:475: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode". (cherry picked from commit e70e257)
This tries to fixes the following defects reported by covscan tool: - channels/smartcard/client/smartcard_operations.c:958: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return". - channels/smartcard/client/smartcard_operations.c:932: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return". But I am not sure about it... (cherry picked from commit 5345988)
(cherry picked from commit d1b310d)
(cherry picked from commit 6ed765c)
Currently, this sets an invalid open flag and attempts to open(), which will fail. Instead of doing that, don't try to define O_TMPFILE where such a definition can't exist and force the fallback rather than making an always-fail open() call. (cherry picked from commit 082ddb3)
(cherry picked from commit 51d3e07)
(cherry picked from commit ea4df3f)
(cherry picked from commit 4e7b60b)
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
CVE-2020-11099 thanks to @antonio-morales for finding this. (cherry picked from commit 6ade7b4)
CVE-2020-11098 thanks to @antonio-morales for finding this. (cherry picked from commit c0fd449)
(cherry picked from commit 057b6df)
(cherry picked from commit 240fdd0)
(cherry picked from commit 36478d3)
(cherry picked from commit 6d86e20)
(cherry picked from commit 3ac7bb5)
(cherry picked from commit 1a02af5)
(cherry picked from commit a45afe9)
(cherry picked from commit c3a1ed7)
CVE-2020-11095 thanks @antonio-morales for finding this. (cherry picked from commit 733ee32)
CVE-2020-11096 thanks @antonio-morales for finding this. (cherry picked from commit b8beb55)
CVE-2020-4030 thanks to @antonio-morales for finding this. (cherry picked from commit 05cd9ea)
CVE-2020-4032 thanks to @antonio-morales for finding this. (cherry picked from commit e7bffa6)
CVE-2020-4033 thanks to @antonio-morales for finding this. (cherry picked from commit 0a98c45)
CVE-2020-4031 thanks to @antonio-morales for finding this. (cherry picked from commit f753c25)
(cherry picked from commit 1c6a692)
CVE-2020-11097 thanks to @antonio-morales for finding this. (cherry picked from commit 58a3122)
(cherry picked from commit 308c2c3)
(cherry picked from commit caff018)
Thanks @anticomputer for pointing this out (cherry picked from commit 02c5ec6)
(cherry picked from commit 5dc50f6)
bmiklautz
approved these changes
Jun 22, 2020
|
Refer to this link for build results (access rights to CI server needed): |
mfleisz
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.