Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Stream validity - Security Enhancement #7321

Closed
wants to merge 1 commit into from
Closed

Enforce Stream validity - Security Enhancement #7321

wants to merge 1 commit into from

Commits on Oct 3, 2021

  1. Enforce Stream validity - Security Enhancement 

    Input parsing of incoming messages is extermely fragile, and once
the pointer passed the buffer's end, the sanity check macros will
return a huge size_t size instead of a negative value, thus bypassing
all future checks in the code.

Change the checks to use ssize_t and upon every release/free make
sure that the Stream didn't reach a corrupted state. This ensures
that an attacker triggering a read/write out-of-bounds will terminate
the program instead of allowing the attacker to continue their
exploit.

Would have blocked CVE-2020-9497 (all 3 variants), CVE-2020-13396,
CVE-2020-11526, CVE-2020-11088 and more.
    Eyal Itkin committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    30b6c63 View commit details
    Browse the repository at this point in the history