Bitmap update fix #7349
Merged
Bitmap update fix #7349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data received from the server might have invalid values for bitmap with or height. Abort parsing if such a value is found. Reported by Sunglin from the Knownsec 404 team & 0103 sec team
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
added a commit
to akallabeth/FreeRDP
that referenced
this pull request
Oct 15, 2021
* Added checks for bitmap width and heigth values Data received from the server might have invalid values for bitmap with or height. Abort parsing if such a value is found. Reported by Sunglin from the Knownsec 404 team & 0103 sec team * Added checks for glyph width & height
akallabeth
added a commit
to akallabeth/FreeRDP
that referenced
this pull request
Oct 15, 2021
* Added checks for bitmap width and heigth values Data received from the server might have invalid values for bitmap with or height. Abort parsing if such a value is found. Reported by Sunglin from the Knownsec 404 team & 0103 sec team * Added checks for glyph width & height
akallabeth
added a commit
to akallabeth/FreeRDP
that referenced
this pull request
Oct 15, 2021
* Added checks for bitmap width and heigth values Data received from the server might have invalid values for bitmap with or height. Abort parsing if such a value is found. Reported by Sunglin from the Knownsec 404 team & 0103 sec team * Added checks for glyph width & height
alexandru-bagu
pushed a commit
to alexandru-bagu/FreeRDP
that referenced
this pull request
Oct 19, 2021
* Added checks for bitmap width and heigth values Data received from the server might have invalid values for bitmap with or height. Abort parsing if such a value is found. Reported by Sunglin from the Knownsec 404 team & 0103 sec team * Added checks for glyph width & height
mfleisz
pushed a commit
that referenced
this pull request
Oct 21, 2021
* Fixed typo in changelog * Fix FIPS mode support and build with OpenSSL 3.0 FreeRDP fails to build with OpenSSL 3.0 because of usage of the `FIPS_mode` and `FIPS_mode_set` functions, which were removed there. Just a note that the FIPS mode is not supported by OpenSSL 1.1.* although the mentioned functions are still there (see https://wiki.openssl.org/index.php/FIPS_modules). Let's make FreeRDP build with OpenSSL 3.0 and fix the FIPS mode support. See: https://bugzilla.redhat.com/show_bug.cgi?id=1952937 (cherry picked from commit 26bf281) * winpr: avoid calling FIPS_mode() with OpenSSL 3.0 Fixes: 26bf281 (cherry picked from commit 0c81c73) * winpr/crypto: Load legacy provider to fix rc4 with OpenSSL 3.0 (#7210) * winpr/crypto: Exit cleanly when EVP_EncryptInit_ex fails The `EVP_EncryptInit_ex` function may fail in certain configurations. Consequently, FreeRDP segfaults in `EVP_CIPHER_CTX_set_key_length`. Let's handle the `EVP_EncryptInit_ex` failures and exit cleanly in such case. * winpr/crypto: Load legacy provider to fix rc4 with OpenSSL 3.0 Currently, the `EVP_EncryptInit_ex` function fails for rc4 with OpenSSL 3.0. This is becuase rc4 is provided by the legacy provider which is not loaded by default. Let's explicitly load the legacy provider to make FreeRDP work with OpenSSL 3.0. Relates: openssl/openssl#14392 Fixes: #6604 (cherry picked from commit 67f3fff) Conflicts: winpr/libwinpr/crypto/cipher.c * Fix TestUnicodeConversion on big endian machines (#7219) Wide character literals are stored in native byte order. Use an array of bytes as a reference instead. Fixes: #6968 (cherry picked from commit 5208a67) * Fixed async-input quit * Fix data write on usb channel * Bitmap update fix (#7349) * Added checks for bitmap width and heigth values Data received from the server might have invalid values for bitmap with or height. Abort parsing if such a value is found. Reported by Sunglin from the Knownsec 404 team & 0103 sec team * Added checks for glyph width & height * Fixed #7363: Length checks in ConvertUTF8toUTF16 (cherry picked from commit 623a772) * Implemented missing TSG debug functions (cherry picked from commit c06c463) * Refactored RPC gateway parser Utilize wStream instead of custom binary parsing code, add proper input validation. Reported by Sunglin from the Knownsec 404 team & 0103 sec team (cherry picked from commit f0b44da) * Replaced chmod with safer fchmod * Use fchmod so the file may not change underneath * Add unit tests for SetFileAttributesA * Add warning logs for unsupported flags (cherry picked from commit c8571dd) * Updated changelog and version * Added more explicit warning for deprecated command line * Add exit codes for more errors (cherry picked from commit aa4c3df) * Updated changelog. Co-authored-by: Ondrej Holy <oholy@redhat.com> Co-authored-by: Mike Gilbert <floppym@gentoo.org> Co-authored-by: Ondrej Holy <ondrejholy@users.noreply.github.com> Co-authored-by: Ian Weir <mr.weir@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.