Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports 10bit X11 color (BGRX32 only) #7733

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

kazuki
Copy link
Contributor

@kazuki kazuki commented Mar 20, 2022

Tested: Gentoo + Xfce + amdgpu + 30bit (BGRX32 + Little-Endian)
Partial-Fixed: #7731

@freerdp-bot
Copy link

Can one of the admins verify this patch?

@akallabeth akallabeth added this to the next milestone Mar 20, 2022
@akallabeth
Copy link
Member

@freerdp-bot test

Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, can´t test though due to lack of such a setup.

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/7251/

@akallabeth
Copy link
Member

Merging as is and waiting for feedback.
Should not interfere with existing code paths as it is entirely dependent on your local X11 setup.

@akallabeth akallabeth merged commit 98f9aed into FreeRDP:master Mar 20, 2022
@Quppa
Copy link

Quppa commented Mar 20, 2022

I can verify this works locally (Fedora + KDE + amdgpu) - thanks for the quick patch @kazuki.

@Quppa
Copy link

Quppa commented Apr 19, 2022

Is there any possibility of this being backported to stable 2.x?

@akallabeth
Copy link
Member

@Quppa usually creating an issue or doing a backport pull request is the fastest way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 10bit X11 color
4 participants