Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ALAW/ULAW from supported backend formats #8041

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

akallabeth
Copy link
Member

pulse/alsa/oss do not reliably work with ALAW/ULAW codecs with all
hardware available.
Since these formats are poor quality anyway, deactivate them for
audin channel.

pulse/alsa/oss do not reliably work with ALAW/ULAW codecs with all
hardware available.
Since these formats are poor quality anyway, deactivate them for
audin channel.
@akallabeth akallabeth added this to the next milestone Jul 5, 2022
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/7782/

The codec does not work reliably with some hardware.
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/7783/

@hardening
Copy link
Contributor

LGTM.
Looking at the changes, perhaps we can add ALAW/ULAW with default: statements in switch/case and add a comment saying that we don't want support these (could help in the future if people want to contribute back support for alaw/ulaw).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants