fix warnings in static inline functions in installed headers #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
= { 0 } has different meaning in C and C++: in C it initialises all
members to 0, in C++ only the first one so the compiler warns that other
members are not initialised. Use an empty initialiser list instead.
|
Can one of the admins verify this patch? |
hardening
approved these changes
Apr 7, 2023
|
@freerdp-bot can you test that my friend ? |
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
reviewed
Apr 7, 2023
| *pcbe = empty; | ||
| pcbe->Version = 1; | ||
| } | ||
|
|
||
| static INLINE VOID DestroyThreadpoolEnvironment(PTP_CALLBACK_ENVIRON pcbe) | ||
| { | ||
| /* no actions, this may change in a future release. */ | ||
| (void)pcbe; |
|
Looking at these functions, it might be the better option to make them normal functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= { 0 } has different meaning in C and C++: in C it initialises all members to 0, in C++ only the first one so the compiler warns that other members are not initialised. Use an empty initialiser list instead.
It's not very pretty; if you prefer a different style let me know :)