Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rel mouse fixes #9677

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Rel mouse fixes #9677

merged 2 commits into from
Dec 19, 2023

Conversation

akallabeth
Copy link
Member

No description provided.

[client,common] fix relative mouse event detect
be4183a 
Only send relative mouse events, if the client explicitely enabled them,
the calling function is reporting the events as relative and the server
announced support for it.
@akallabeth akallabeth added this to the stable-3.0-next milestone Dec 19, 2023
[server,shadow] force relative mouse disabled
98f29dd 
Since we do not implement the required callbacks ensure we do not send
the capability for it to connecting clients.
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11011/

@hardening
Copy link
Contributor

Don't we have the same concern in the SDL client (IIRC I had the same behaviour)

@akallabeth akallabeth mentioned this pull request Dec 19, 2023
Closed
@akallabeth
Copy link
Member Author

@hardening no, there the relative coordinates are always available and we just check freerdp_client_use_relative_mouse_events and if TRUE send the relative coordinates, else the absolute ones.

@akallabeth
Copy link
Member Author

akallabeth commented Dec 19, 2023 •
edited

@hardening this bug was in client/common though, so it ignored what the client was telling the library
so, basically whenever the server supports relative mouse events, the client/common was sending everything as relative event regardless of what the client told the library

@akallabeth akallabeth linked an issue Dec 19, 2023 that may be closed by this pull request
Login to Azure Virtual Desktop crashes #9521
Closed
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11012/

hardening
hardening approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@hardening hardening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hardening hardening merged commit 3735440 into FreeRDP:master Dec 19, 2023
3 checks passed
@akallabeth akallabeth deleted the rel_mouse_fixes branch December 19, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardening hardening hardening approved these changes

@pnowack pnowack Awaiting requested review from pnowack

@bmiklautz bmiklautz Awaiting requested review from bmiklautz

@mfleisz mfleisz Awaiting requested review from mfleisz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Login to Azure Virtual Desktop crashes
3 participants
@akallabeth @freerdp-bot @hardening