Prevent write at NULL when codec configured not to use multiple threads #9712
Conversation
|
Can one of the admins verify this patch? |
alega-kas
force-pushed
the
fix_codec_progressive_failure
branch
from
1a6a456
to
ec3b7a2
Compare
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
@akallabeth Does the error mean CI is not configured for PRs into stable-2.0 branch properly? |
|
@alega-kas means we did not yet backport openssl 3 support to stable-2.0 |
|
|
@freerdp-bot test |
|
@alega-kas no, I´m fixing this. |
|
OK, I stop working on this PR. |
|
Refer to this link for build results (access rights to CI server needed): |
|
@alega-kas ok, now it compiles. you need to format your changes though, the format checker fails. |
When RFX_CONTEXT_PRIV::UseThreads is set to 0, progressive_process_tiles() function will not attempt to write at memory address 0.
alega-kas
force-pushed
the
fix_codec_progressive_failure
branch
from
ec3b7a2
to
55c3bb8
Compare
@akallabeth It seems freerdp-bot need to be launched manually. |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
Progressive codec accessed 0 memory address when the following condition was met:
Inside
progressive.c: WhenRFX_CONTEXT_PRIV::UseThreadswas set to 0,progressive_process_tiles()function wrote at memory address 0.