[libuwac] fix keyboard "sticky" keys when entering window #9725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
The change seems to be working fine... but I have sometimes the situation, that when I enter a freerdp window and start typing I have some modifier key active and I have to press all modifier keys to have it return to normal state... |
The commit is fixing the following problem: When the freerdp window gets keyboard focus and is notified, it wrongly process keys which are *held*, not a freshly pressed. The comment in the code explains it more.
The commit is fixing the problem when eg. a user is pressing some modifier key to switch from active FreeRDP window and when get back to that window, it "virtually" has that modifier key pressed, thus leading to pressing eg. `Win+r` instead of just `r`.
|
Hi again, Edit: also added one fix for the scaling code as it is also for uwac |
Fix for a hybrid multimonitor configurations: Previous code was working for me because the display with scale=2 was last on the wayland display list. After restarting it was earlier. To fix this - just take the highest scale provided by a display. Similar as eg. here the SDL is doing: https://github.com/libsdl-org/SDL/blob/b5bc64aa553fe12d09fe2821eace14ea5b948bd9/src/video/wayland/SDL_waylandwindow.c#L1170
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit is fixing the following problem:
When the freerdp window gets keyboard focus and is notified, it wrongly process keys which are held, not a freshly pressed.
The comment in the code explains it more.