Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winpr image improve #9826

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Winpr image improve #9826

merged 5 commits into from
Feb 7, 2024

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Feb 2, 2024 •
edited
Loading

Improve the winpr_image_* API:

  • Add missing functions, refine existing onew
  • Add (optional) support for PNG, JPEG and WEBP alongside BMP
  • Use this in libfreerdp/codec/jpeg.c instead of custom implementation
  • Enable image support in nightly builds

this is required base work to implement #9823

@akallabeth akallabeth added this to the next-3.0 milestone Feb 2, 2024
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11314/

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
winpr/libwinpr/utils/image.c Fixed Show fixed Hide fixed
winpr/libwinpr/utils/image.c Fixed Show fixed Hide fixed
winpr/libwinpr/utils/image.c Fixed Show fixed Hide fixed
winpr/libwinpr/utils/image.c Fixed Show fixed Hide fixed
winpr/libwinpr/utils/image.c Fixed Show fixed Hide fixed
winpr/libwinpr/utils/image.c Fixed Show fixed Hide fixed
@akallabeth akallabeth force-pushed the winpr_image_improve branch 2 times, most recently from eb32a41 to d273648 Compare February 2, 2024 14:55
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11315/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11316/

@akallabeth akallabeth force-pushed the winpr_image_improve branch 2 times, most recently from 9ed0862 to 6017348 Compare February 2, 2024 15:02
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11317/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11318/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11319/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11320/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11321/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11322/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11323/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11324/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11326/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11327/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11328/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11352/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11353/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11361/

@akallabeth
Copy link
Member Author

ready for review, rebased to current master.

@mfleisz mfleisz merged commit 31763e2 into FreeRDP:master Feb 7, 2024
3 checks passed
@akallabeth akallabeth deleted the winpr_image_improve branch February 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfleisz mfleisz mfleisz approved these changes

@bmiklautz bmiklautz Awaiting requested review from bmiklautz

@hardening hardening Awaiting requested review from hardening

@pnowack pnowack Awaiting requested review from pnowack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akallabeth @freerdp-bot @mfleisz