Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang tidy loop #9834

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Clang tidy loop #9834

merged 6 commits into from
Feb 22, 2024

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Feb 4, 2024 •
edited

follow up #9799

@akallabeth akallabeth added this to the next-3.0 milestone Feb 4, 2024
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11338/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11339/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11340/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11341/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11342/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11343/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11344/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11345/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11346/

@akallabeth akallabeth force-pushed the clang-tidy-loop branch 2 times, most recently from 67a08af to e894c80 Compare February 4, 2024 19:55
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11347/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11348/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11349/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11350/

@akallabeth
Copy link
Member Author

@freerdp-bot test please

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11351/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11370/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11438/

github-actions[bot]
github-actions bot reviewed Feb 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 54. Check the log or trigger a new build to see more.

channels/drdynvc/client/drdynvc_main.c Outdated Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Outdated Show resolved Hide resolved
libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
@akallabeth akallabeth force-pushed the clang-tidy-loop branch 2 times, most recently from 6d965d6 to 2f1df4c Compare February 12, 2024 10:16
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11444/

github-actions[bot]
github-actions bot reviewed Feb 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 29. Check the log or trigger a new build to see more.

libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
libfreerdp/primitives/prim_YUV_opencl.c Outdated Show resolved Hide resolved
libfreerdp/primitives/test/TestPrimitivesColors.c Outdated Show resolved Hide resolved
libfreerdp/primitives/test/TestPrimitivesYCoCg.c Outdated Show resolved Hide resolved
scripts/LECHash.c Show resolved Hide resolved
winpr/libwinpr/sspi/sspi_winpr.c Show resolved Hide resolved
winpr/libwinpr/sspi/sspi_winpr.c Show resolved Hide resolved
winpr/libwinpr/sspi/sspi_winpr.c Show resolved Hide resolved
winpr/libwinpr/synch/test/TestSynchCritical.c Show resolved Hide resolved
winpr/libwinpr/synch/test/TestSynchCritical.c Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Feb 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

winpr/libwinpr/sysinfo/cpufeatures/cpu-features.c Outdated Show resolved Hide resolved
winpr/libwinpr/sysinfo/cpufeatures/cpu-features.c Outdated Show resolved Hide resolved
winpr/libwinpr/sysinfo/cpufeatures/cpu-features.c Outdated Show resolved Hide resolved
winpr/libwinpr/utils/test/TestArrayList.c Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11445/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11476/

@akallabeth akallabeth marked this pull request as ready for review February 15, 2024 11:48
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11479/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11497/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11499/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11505/

@akallabeth
Copy link
Member Author

@freerdp-bot test again please

github-actions[bot]
github-actions bot reviewed Feb 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

libfreerdp/gdi/test/TestGdiBitBlt.c Show resolved Hide resolved
libfreerdp/gdi/test/helpers.c Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11507/

@akallabeth akallabeth merged commit 05175d7 into FreeRDP:master Feb 22, 2024
3 checks passed
@akallabeth akallabeth deleted the clang-tidy-loop branch February 22, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@hardening hardening hardening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akallabeth @freerdp-bot @hardening