Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitmap formats #9873

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Bitmap formats #9873

merged 6 commits into from
Feb 22, 2024

Conversation

akallabeth
Copy link
Member

No description provided.

@akallabeth akallabeth added this to the next-3.0 milestone Feb 14, 2024
@akallabeth akallabeth linked an issue Feb 14, 2024 that may be closed by this pull request
Add clipboard support for JPG/JPEG, PNG, GIF, ICO, WEBP formats #9823
Closed
github-actions[bot]
github-actions bot reviewed Feb 14, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/X11/xf_cliprdr.c Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11467/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11468/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11469/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11470/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11471/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11472/

github-actions[bot]
github-actions bot reviewed Feb 15, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/Wayland/wlf_cliprdr.c Outdated Show resolved Hide resolved
client/Wayland/wlf_cliprdr.c Outdated Show resolved Hide resolved
client/Wayland/wlf_cliprdr.c Outdated Show resolved Hide resolved
client/Wayland/wlf_cliprdr.c Outdated Show resolved Hide resolved
client/X11/xf_cliprdr.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11473/

@akallabeth akallabeth mentioned this pull request Feb 15, 2024
Closed
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11474/

github-actions[bot]
github-actions bot reviewed Feb 15, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

winpr/libwinpr/clipboard/synthetic.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11477/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11478/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11480/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11488/

@akallabeth akallabeth force-pushed the bitmap_formats branch 3 times, most recently from c1e4555 to e89ed35 Compare February 19, 2024 08:22
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11489/

github-actions[bot]
github-actions bot reviewed Feb 19, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

winpr/libwinpr/utils/image.c Outdated Show resolved Hide resolved
winpr/libwinpr/utils/image.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11490/

github-actions[bot]
github-actions bot reviewed Feb 19, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

winpr/libwinpr/utils/image.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11491/

@akallabeth akallabeth force-pushed the bitmap_formats branch 2 times, most recently from bbe9bdc to 1a0dfcf Compare February 19, 2024 08:31
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11492/

akallabeth and others added 5 commits February 19, 2024 09:33
@akallabeth
[winpr,utils] improve winpr image API
8e428fd 
* Add checks for bitmap read functions
* Add more unit tests
* Do not expose internals to WinPR
@akallabeth
[winpr,clipboard] support alternate bitmap mime types
17e6c67
@akallabeth
[client,x11] add alternate bitmap mime types
bf40540 
announce alternate mime types to clipboard
@akallabeth
[client,wayland] add alternate bitmap mime types
f9a3d51 
add alternate bitmap mime types to clipboard
@akallabeth
[ci,qa] enable additional image formats
cd64b96
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11493/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11494/

@akallabeth
Copy link
Member Author

confirmed fixed by reporter.

@akallabeth akallabeth merged commit 118f43b into FreeRDP:master Feb 22, 2024
3 checks passed
@akallabeth akallabeth deleted the bitmap_formats branch February 22, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@bmiklautz bmiklautz Awaiting requested review from bmiklautz

@mfleisz mfleisz Awaiting requested review from mfleisz

@hardening hardening Awaiting requested review from hardening

@pnowack pnowack Awaiting requested review from pnowack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Add clipboard support for JPG/JPEG, PNG, GIF, ICO, WEBP formats
2 participants
@akallabeth @freerdp-bot