Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdl tidy up client #9875

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Sdl tidy up client #9875

merged 4 commits into from
Feb 22, 2024

Conversation

akallabeth
Copy link
Member

No description provided.

@akallabeth akallabeth added this to the next-3.0 milestone Feb 15, 2024
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11482/

github-actions[bot]
github-actions bot reviewed Feb 15, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 46. Check the log or trigger a new build to see more.

client/SDL/aad/qt/webview_impl.cpp Show resolved Hide resolved
client/SDL/dialogs/sdl_dialogs.cpp Outdated Show resolved Hide resolved
client/SDL/dialogs/sdl_dialogs.cpp Show resolved Hide resolved
client/SDL/sdl_disp.cpp Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Show resolved Hide resolved
client/SDL/sdl_kbd.hpp Outdated Show resolved Hide resolved
client/SDL/sdl_monitor.cpp Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11483/

github-actions[bot]
github-actions bot reviewed Feb 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Show resolved Hide resolved
client/SDL/sdl_monitor.cpp Show resolved Hide resolved
client/SDL/sdl_monitor.cpp Show resolved Hide resolved
client/SDL/sdl_window.cpp Show resolved Hide resolved
client/SDL/sdl_window.cpp Show resolved Hide resolved
client/SDL/sdl_window.cpp Show resolved Hide resolved
client/SDL/sdl_window.cpp Show resolved Hide resolved
client/SDL/sdl_window.hpp Show resolved Hide resolved
@akallabeth
Copy link
Member Author

@freerdp-bot test

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11484/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11485/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11486/

mfleisz
mfleisz reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@mfleisz mfleisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - added a few minor remarks

client/SDL/dialogs/sdl_button.cpp Outdated Show resolved Hide resolved
client/SDL/dialogs/sdl_buttons.cpp Outdated Show resolved Hide resolved
client/SDL/dialogs/sdl_buttons.cpp Outdated Show resolved Hide resolved
client/SDL/dialogs/sdl_dialogs.cpp Outdated Show resolved Hide resolved
client/SDL/dialogs/sdl_select.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_freerdp.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_utils.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_utils.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_window.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Feb 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/SDL/dialogs/sdl_dialogs.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11508/

@akallabeth akallabeth merged commit a2b220f into FreeRDP:master Feb 22, 2024
3 checks passed
@akallabeth akallabeth deleted the sdl-tidy branch February 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfleisz mfleisz mfleisz left review comments

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akallabeth @freerdp-bot @mfleisz