Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client,sdl] add shortcut config file #9887

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

akallabeth
Copy link
Member

Allow keyboard shortcuts to be configured via config file.

@akallabeth akallabeth added this to the next-3.0 milestone Feb 21, 2024
@akallabeth akallabeth linked an issue Feb 21, 2024 that may be closed by this pull request
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11501/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11502/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
client/SDL/sdl_utils.cpp Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11503/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11504/

Copy link
Member

@mfleisz mfleisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment - overall lgtm

client/SDL/sdl_kbd.cpp Outdated Show resolved Hide resolved
Allow keyboard shortcuts to be configured via config file.
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11506/

@akallabeth akallabeth merged commit 62f974a into FreeRDP:master Feb 22, 2024
3 checks passed
@akallabeth akallabeth deleted the sdl_config_shortcuts branch February 22, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert hardcoded hotkeys into configurable ones
3 participants