-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build with openssl < 1.1.1 #9897
Conversation
Can one of the admins verify this patch? |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
but you most likely mean build with openssl < 1.1.1?
@freerdp-bot test |
Yeah, should I change the commit message to |
Refer to this link for build results (access rights to CI server needed): |
please do so. |
0a7d6ff
to
0d80b10
Compare
clang-tidy review says "All clean, LGTM! 👍" |
@freerdp-bot test |
Refer to this link for build results (access rights to CI server needed): |
I'm building freerdp 3.2.0 on ubuntu xenial with openssl 1.1.0g, and find some openssl vars/funcs are introduced after 1.1.1:
RSA_get0_d
,RSA_get0_e
andRSA_get0_n
are introduced by commit openssl/openssl@6692ff7 in whichOPENSSL_VERSION_NUMBER
is0x10101007L
: https://github.com/openssl/openssl/blob/6692ff7777ea3e75f964de7ee64761ec8565f9be/include/openssl/opensslv.h#L42SSL_OP_NO_RENEGOTIATION
is introduced by commit openssl/openssl@db0f35d in whichOPENSSL_VERSION_NUMBER
is0x10101000L
: https://github.com/openssl/openssl/blob/db0f35dda18403accabe98e7780f3dfc516f49de/include/openssl/opensslv.h#L42EVP_sha512_224()
andEVP_sha512_256()
are introduced by commit openssl/openssl@4bed94f in whichOPENSSL_VERSION_NUMBER
is0x10101000L
: https://github.com/openssl/openssl/blob/4bed94f0c11ef63587c6b2edb03c3c438e221604/include/openssl/opensslv.h#L42This commit will fix build error with openssl 1.1.0g.