Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with openssl < 1.1.1 #9897

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

amazingfate
Copy link
Contributor

I'm building freerdp 3.2.0 on ubuntu xenial with openssl 1.1.0g, and find some openssl vars/funcs are introduced after 1.1.1:

This commit will fix build error with openssl 1.1.0g.

@freerdp-bot
Copy link

Can one of the admins verify this patch?

Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
but you most likely mean build with openssl < 1.1.1?

@akallabeth
Copy link
Member

@freerdp-bot test

@amazingfate
Copy link
Contributor Author

LGTM, but you most likely mean build with openssl < 1.1.1?

Yeah, should I change the commit message to fix build with openssl < 1.1.1?

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11514/

@akallabeth
Copy link
Member

LGTM, but you most likely mean build with openssl < 1.1.1?

Yeah, should I change the commit message to fix build with openssl < 1.1.1?

please do so.

@amazingfate amazingfate changed the title fix build with openssl under 1.1.1 fix build with openssl < 1.1.1 Feb 23, 2024
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@akallabeth
Copy link
Member

@freerdp-bot test

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11515/

@akallabeth akallabeth merged commit e21afef into FreeRDP:master Feb 23, 2024
3 checks passed
@akallabeth akallabeth added this to the next-3.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants