Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crypto,cert] add better logging of certificate read #9943

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

akallabeth
Copy link
Member

add missing log entries for possible failures due to invalid data received. This allows better debugging if a server sends garbage or the crypto routines have direct RSA routine access disabled.

@akallabeth akallabeth added this to the next-3.0 milestone Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11595/

libfreerdp/crypto/cert_common.c Outdated Show resolved Hide resolved
libfreerdp/crypto/cert_common.c Outdated Show resolved Hide resolved
add missing log entries for possible failures due to invalid data
received. This allows better debugging if a server sends garbage or the
crypto routines have direct RSA routine access disabled.
Copy link

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11600/

@mfleisz mfleisz merged commit 6a7c375 into FreeRDP:master Mar 7, 2024
4 checks passed
@akallabeth akallabeth deleted the log branch March 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants