Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win32,childsession] Fix invalid pipe path with 32 bits builds #9961

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[win32,childsession] Fix invalid pipe path with 32 bits builds #9961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions libfreerdp/core/childsession.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,23 @@ static BOOL createChildSessionTransport(HANDLE* pFile)
goto out;
}

const BYTE startOfPath[] = { '\\', 0, '\\', 0, '.', 0, '\\', 0 };
if (_wcsncmp(pipePath, (WCHAR*)startOfPath, 4))
{
/* when compiled under 32 bits, the path may miss "\\.\" at the beginning of the string
* so add it if it's not there
*/
size_t len = _wcslen(pipePath);
if (len > 0x80 - (8 + 1))
{
WLog_ERR(TAG, "pipePath is too long to be adjusted");
goto out;
}

memmove(pipePath + 8, pipePath, (len + 1) * sizeof(WCHAR));
memcpy(pipePath, startOfPath, 8);
}

ConvertWCharNToUtf8(pipePath, 0x80, pipePathA, sizeof(pipePathA));
WLog_DBG(TAG, "child session is at '%s'", pipePathA);

Expand Down
Loading