Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC arm64 #9964

Merged
merged 1 commit into from Mar 12, 2024
Merged

Fix MSVC arm64 #9964

merged 1 commit into from Mar 12, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 12, 2024

From vcpkg port, fixes:

FAILED: freerdp3.dll freerdp3.lib 
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.27.1-windows\cmake-3.27.1-windows-i386\bin\cmake.exe -E vs_link_dll --intdir=libfreerdp\CMakeFiles\freerdp.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\arm64\link.exe  @CMakeFiles\freerdp.rsp  /out:freerdp3.dll /implib:freerdp3.lib /pdb:freerdp3.pdb /dll /version:3.3 /machine:ARM64 /nologo    /debug /INCREMENTAL  /INCREMENTAL:NO /LTCG  && cd ."
LINK: command "C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\arm64\link.exe @CMakeFiles\freerdp.rsp /out:freerdp3.dll /implib:freerdp3.lib /pdb:freerdp3.pdb /dll /version:3.3 /machine:ARM64 /nologo /debug /INCREMENTAL /INCREMENTAL:NO /LTCG /MANIFEST:EMBED,ID=2" failed (exit code 1120) with the following output:
   Creating library freerdp3.lib and object freerdp3.exp


rfx_rlgr.c.obj : error LNK2001: unresolved external symbol __lzcnt


freerdp3.dll : fatal error LNK1120: 1 unresolved externals

@freerdp-bot
Copy link

Can one of the admins verify this patch?

Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akallabeth akallabeth added this to the next-3.0 milestone Mar 12, 2024
@akallabeth
Copy link
Member

@freerdp-bot test please

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11635/

@akallabeth akallabeth merged commit 47354c4 into FreeRDP:master Mar 12, 2024
4 checks passed
@dg0yt dg0yt deleted the msvc-arm64 branch March 12, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants