Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building pool with (older?) mingw #9965

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 12, 2024

From vpckg port, build locally on Ubuntu 20.04.
Fixes #9881.

@freerdp-bot
Copy link

Can one of the admins verify this patch?

Copy link

clang-tidy review says "All clean, LGTM! 👍"

@hardening
Copy link
Contributor

@freerdp-bot can you test that buddy ?

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11634/

@dg0yt dg0yt marked this pull request as draft March 12, 2024 07:48
winpr/libwinpr/pool/pool.c Outdated Show resolved Hide resolved
@dg0yt dg0yt marked this pull request as ready for review March 12, 2024 08:05
Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

clang-tidy review says "All clean, LGTM! 👍"

@akallabeth akallabeth added this to the next-3.0 milestone Mar 12, 2024
@akallabeth
Copy link
Member

@freerdp-bot test please

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11636/

@akallabeth akallabeth merged commit f2f9c59 into FreeRDP:master Mar 12, 2024
4 checks passed
@dg0yt dg0yt deleted the mingw-tp branch March 13, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while cross compiling freerdp.
4 participants