Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posix refactor #9995

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Posix refactor #9995

merged 7 commits into from
Mar 20, 2024

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Mar 19, 2024

  • unify POSIX checks
  • supply platform defaults for known systems at a single location (not completed yet)
  • move #ifdef madness to (configurable) CMake file as far as possible

* Split POSIX and BSD implementations
* Add stub for unuspported platforms
* generate a include header depending on where the soundcard.h file was
  found as that is in system paths that must not be added to the include
  search paths.
* fix detection, the if/else was mixed up and completely broken.
* Move platform specific settings to a common CMake include
allow defining the filepath of timezone file in buildsystem adjusting it
without a required code change.
@akallabeth akallabeth added this to the next-3.0 milestone Mar 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

winpr/libwinpr/file/file.c Show resolved Hide resolved
winpr/libwinpr/file/file.c Show resolved Hide resolved
winpr/libwinpr/file/file.c Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11668/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11669/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11670/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11671/

Copy link
Contributor

@hardening hardening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me

@akallabeth akallabeth marked this pull request as ready for review March 19, 2024 22:02
@akallabeth akallabeth merged commit 9031727 into FreeRDP:master Mar 20, 2024
4 checks passed
@akallabeth akallabeth deleted the posix_refactor branch March 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants