-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posix refactor #9995
Posix refactor #9995
Conversation
* Split POSIX and BSD implementations * Add stub for unuspported platforms
* generate a include header depending on where the soundcard.h file was found as that is in system paths that must not be added to the include search paths. * fix detection, the if/else was mixed up and completely broken.
* Move platform specific settings to a common CMake include
allow defining the filepath of timezone file in buildsystem adjusting it without a required code change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
ffda4d4
to
8289a2b
Compare
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok for me
POSIX
checks#ifdef
madness to (configurable)CMake
file as far as possible