sbom-generator: Fix FilesAnalyzed boolean value #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FilesAnalyzed boolean value as per SPDX spec is lowercase. Spec: https://spdx.github.io/spdx-spec/v2.3/package-information/#7.8 Without this fix, the generated SPDX SBOM fails the validator tool. https://github.com/spdx/tools-java/releases $ java -jar tools-java-1.1.8-jar-with-dependencies.jar Verify sbom.spdx This SPDX Document is not valid due to: Warning: Invalid case for boolean value. Expected 'true', found 'True' https://tools.spdx.org/app/validate/ The following warning(s) were raised:<br /> Warning: Invalid case for boolean value. Expected 'true', found 'True' Signed-off-by: Akshay Bhat <nodeax@gmail.com>
|
Thanks for this fix. |
tony-josi-aws
approved these changes
Apr 1, 2024
paulbartell
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FilesAnalyzed boolean value as per SPDX spec is lowercase.
Spec:
https://spdx.github.io/spdx-spec/v2.3/package-information/#7.8
Without this fix, the generated SPDX SBOM fails the validator tool. https://github.com/spdx/tools-java/releases
https://tools.spdx.org/app/validate/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.