Fix use of removed macro in ATSAME5x network interface #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-josi-aws
approved these changes
Apr 19, 2024
shubnil
approved these changes
Apr 22, 2024
apcountryman
deleted the
fix_use_of_removed_macro_in_atsame5x_network_interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ipCAST_CONST_PTR_TO_CONST_TYPE_PTR()macro was removed by a412460 but was still used in the ATSAME5x network interface which resulted in a compilation errors. This PR replaces the uses of the macro with direct casts (#491 (review)).Test Steps
The compilation errors were encountered in a project that is using the ATSAME5x network interface. The compilation errors have been resolved by the changes made in this PR.
The instructions from https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/test/build-combination/README.md#unix-linux-and-mac have also been executed and no errors were encountered.
Checklist:
Related Issue
None.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.