IPv4/single: STM32H7xx driver check result of HAL_ETH_Init #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
approved these changes
Jun 7, 2022
|
@AniruddhaKanhere Hi, I just wanted to manually update from V2.4.0 to V4.0.0. Upon diffing my local fixes with the release I noticed that commit ab881bf reverted these proposed changes again. Do I understand the git history correctly here or is this intended? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was originally created by @htibosch. I am rebasing his PR and closing the original one: #465
This PR is in response to an issue reported on the FreeRTOS forum.
The function
HAL_ETH_Init()checks if the PHY hardware is OK. The result of the function was not checked, which may result in a crash.Dweb_2, thank you for reporting this.
Test Steps
It is difficult to reproduce without changing the hardware.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.