Update APIs to detect partial sends as failures #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Muneeb Ahmed <54290492+muneebahmed10@users.noreply.github.com>
muneebahmed10
approved these changes
Dec 7, 2020
gkwicker
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All library API functions call
sendPacketto send an entire MQTT packet over the network.With the addition of a send timeout (with
MQTT_SEND_RETRY_TIMEOUT_MSconfiguration) in PR #124, the APIs should detect partial packet (or zero bytes) transmission as send failures.This PR updates the
MQTT_Connect,MQTT_Disconnect,MQTT_Subscribe,MQTT_UnsubscibeandMQTT_PingAPI functions to returnMQTTSendFailedfor partial packet transmissions.Note: The
MQTT_Publishfunction was updated for the same already in PR#124