Check for empty topic filters in subscribes #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Serializing a SUBSCRIBE or UNSUBSCRIBE packet using either the managed or serializer API will not return an error if zero length topic filter is passed. This adds a check to
calculateSubscriptionPacketSize, used byMQTT_GetSubscribePacketSizeandMQTT_GetUnsubscribePacketSize, to validate the topic length of each filter. SinceMQTT_Subscribeinternally callsMQTT_GetSubscribePacketSize, a bad parameter error code will be propagated back if an invalid topic filter length is passed.Side note: This change resulted in the GNU complexity of
calculateSubscriptionPacketSizeincreasing from 3 to 6. While this is still under our limit, it's concerning that complexity doubled due to what amounts to anifstatement and setting a return code.