Fixes to timeout of sendMessageVector and refactor of sendBuffer for consistency #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpcarroll
force-pushed
the
timeoutFixes
branch
8 times, most recently
from
c99dab5
to
6226708
Compare
jasonpcarroll
force-pushed
the
timeoutFixes
branch
from
6226708
to
2900e20
Compare
AniruddhaKanhere
requested changes
Oct 4, 2022
jasonpcarroll
force-pushed
the
timeoutFixes
branch
from
0591341
to
ae2eb85
Compare
AniruddhaKanhere
requested changes
Oct 12, 2022
AniruddhaKanhere
requested changes
Oct 13, 2022
There was a problem hiding this comment.
Thank you for this PR @jasonpcarroll, can you make just one small change?
AniruddhaKanhere
approved these changes
Oct 13, 2022
Skptak
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes sendMessageVector improperly timing out and refactors both sendMessageVector and sendBuffer to be consistent with one another in their logic.