Align wording of Init with porting guide #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhidixi11
reviewed
Oct 29, 2020
| @@ -231,8 +231,9 @@ typedef struct MQTTDeserializedInfo | |||
| * @note The #MQTTGetCurrentTimeFunc_t callback function must be defined. If | |||
| * there is no time implementation, it is the responsibility of the application | |||
| * to provide a dummy function to always return 0, and provide 0 timeouts for | |||
| * functions. This will ensure all time based functions will run for a single | |||
There was a problem hiding this comment.
Can we add similar @note on top of these three functions as well ?
muneebahmed10
force-pushed
the
init-wording
branch
from
71fb754
to
e8b5efa
Compare
abhidixi11
approved these changes
Oct 30, 2020
n9wxu
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change note in documentation of
MQTT_Initto explicitly mention which functions need the time function as the porting guide does.