fix: compiler warnings in ARM GCC, MCUX, MDK #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookpate
force-pushed
the
cookpate_fix_warnings
branch
from
66f0b8f
to
0e63b78
Compare
This fixes several implicit function declaration warnings
this fixes implicit function declaration warnings.
This macro already exists in fsl_flexspi
The enum is defined in a header, generating warnings in IAR and MDK
Emits warnings on MDK. Looks accidentally placed. Macro looks like NULL.
Emits warning in MCU's compiler. It's a near-duplicate of boot_swap_test
cookpate
force-pushed
the
cookpate_fix_warnings
branch
from
31fc15d
to
39f1ffd
Compare
archigup
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: compiler warnings with ARM GCC, MCUX, MDK
Description
This is not an exhaustive fix, but these commits fix several warnings enabled by
-Wallemitted by ARM GCC, MCUX, or MDK.Fixes include explicitly casting types where it is safe to do so, removing undefined behaviour, and removing unused code.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.